Bumps solana-sbpf to v0.9.0 #3830
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
Lichtso
force-pushed
the
rbpf/v0.9.0
branch
3 times, most recently
from
2c0e201 to
a9c8f59
Compare
Lichtso
force-pushed
the
rbpf/v0.9.0
branch
2 times, most recently
from
ed52de2 to
9e667e9
Compare
Lichtso
force-pushed
the
rbpf/v0.9.0
branch
2 times, most recently
from
bd28e00 to
8bed666
Compare
Lichtso
force-pushed
the
rbpf/v0.9.0
branch
2 times, most recently
from
4161b3a to
690c82a
Compare
Lichtso
force-pushed
the
rbpf/v0.9.0
branch
2 times, most recently
from
e7a4940 to
32909f0
Compare
There was a problem hiding this comment.
Shouldn't we have a test for each one of the SBPF versions? At some point, we'll have all four of them running online.
I believe that at least such a test should exist for the program in programs/sbf.
There was a problem hiding this comment.
Agreed, however currently these test binaries are manually constructed. We can revisit this topic once we have actual toolchain support for all these SBPF versions.
Lichtso
force-pushed
the
rbpf/v0.9.0
branch
4 times, most recently
from
1a4b7f2 to
d1b8459
Compare
| @@ -555,13 +555,13 @@ impl<'a> InvokeContext<'a> { | |||
| // For now, only built-ins are invoked from here, so the VM and its Config are irrelevant. | |||
| let mock_config = Config::default(); | |||
| let empty_memory_mapping = | |||
| MemoryMapping::new(Vec::new(), &mock_config, &SBPFVersion::V1).unwrap(); | |||
| MemoryMapping::new(Vec::new(), &mock_config, SBPFVersion::V1).unwrap(); | |||
| SBPFVersion::V1 | ||
| } else { | ||
| SBPFVersion::V0 | ||
| }; |
There was a problem hiding this comment.
It would be nice to have a debug assert here to prevent min_sbpf_version from being greater than the max_sbpf_version.
I know we plan on enabling enable_sbpf_v3_deployment_and_execution before activating disable_sbpf_v0_execution, but any case different than that should error out (at least in debug mode).
| @@ -12183,7 +12182,7 @@ fn test_feature_activation_loaded_programs_cache_preparation_phase() { | |||
| result_with_feature_enabled, | |||
| Err(TransactionError::InstructionError( | |||
| 0, | |||
| InstructionError::InvalidAccountData | |||
| InstructionError::UnsupportedProgramId | |||
There was a problem hiding this comment.
Enabling all features with let mut feature_set = FeatureSet::all_enabled(); did also activate remove_accounts_executable_flag_checks which changes the error message here.
Problem
solana-sbpf v0.9.0 was released.
Summary of Changes
solana_rbpf=>solana-sbpfdisable_sbpf_v1_execution=>disable_sbpf_v0_executionreenable_sbpf_v1_execution=>reenable_sbpf_v0_executionenable_sbpf_v1_deployment_and_executionenable_sbpf_v2_deployment_and_executionenable_sbpf_v3_deployment_and_executionNot included in this PR